Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[iOS] Fix usage of iOS11 api #5893

Merged
merged 2 commits into from Apr 15, 2019
Merged

[iOS] Fix usage of iOS11 api #5893

merged 2 commits into from Apr 15, 2019

Conversation

rmarinho
Copy link
Member

@rmarinho rmarinho commented Apr 11, 2019

Description of Change

Don't call iOS11 APIs on iOS10 or lower.

Issues Resolved

  • None

API Changes

None

Platforms Affected

  • iOS

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

Should fix iOS10 UITests

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard

@samhouts
Copy link
Member

@rmarinho Still failing on iOS10 :(

@samhouts samhouts added blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. p/iOS 🍎 labels Apr 15, 2019
@samhouts
Copy link
Member

Failing tests not related!

@samhouts samhouts merged commit 4f0724f into 4.0.0 Apr 15, 2019
@samhouts samhouts deleted the fix-ios10home branch April 15, 2019 21:24
@samhouts samhouts added this to Done in v4.0.0 Apr 15, 2019
@samhouts samhouts added this to the 4.0.0 milestone Apr 15, 2019
@samhouts samhouts added the t/housekeeping ♻︎ Internal only changes, won't be included in release notes label Apr 30, 2019
AxelUser pushed a commit to AxelUser/Xamarin.Forms that referenced this pull request Jun 15, 2019
* [iOS] Fix usage of iOS11 api

* [iOS] Fix remaining calls to HomeIndicatorHidden feature
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. p/iOS 🍎 t/housekeeping ♻︎ Internal only changes, won't be included in release notes
Projects
No open projects
v4.0.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants